feat: add ee licensed replay transformer #18874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
marandaneto
reviewed
Nov 28, 2023
marandaneto
reviewed
Nov 28, 2023
marandaneto
reviewed
Nov 28, 2023
marandaneto
reviewed
Nov 28, 2023
marandaneto
reviewed
Nov 28, 2023
pauldambra
commented
Nov 28, 2023
Comment on lines
+5
to
+12
| return import('../../../ee/frontend/exports') | ||
| .then((ee) => { | ||
| return ee.default() | ||
| }) | ||
| .catch(() => { | ||
| return { | ||
| enabled: false, | ||
| } |
There was a problem hiding this comment.
this is the really key change for the ee bundler @benjackwhite
(although even this is reversible)
I couldn't find an esbuild option that looked like it would include this code even if unreferenced. I guess we could mark it as external and then bundle it separately, but that felt less intention revealing than this
daibhin
reviewed
Nov 28, 2023
frontend/src/scenes/session-recordings/player/utils/segmenter.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: David Newell <[email protected]>
Co-authored-by: David Newell <[email protected]>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
benjackwhite
approved these changes
Nov 29, 2023
Comment on lines
+5
to
+12
| return import('../../../ee/frontend/exports') | ||
| .then((ee) => { | ||
| return ee.default() | ||
| }) | ||
| .catch(() => { | ||
| return { | ||
| enabled: false, | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first pass through using the EE licensed replay transformer in playback